Fix #4891: Make scala.quoted.Expr covariant #4894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
reviewed
Aug 4, 2018
|
My first guess is that the infered type is |
Now type inference does not infer `~t` anymore, now it infers `T` which is phase correct. Writing `~t` explicitly still fails as expected (tests/neg/i4774b.scala).
|
LGTM and merged then, since we already have the other test. |
smarter
reviewed
Aug 5, 2018
| @@ -2,7 +2,7 @@ package scala.quoted | |||
|
|
|||
| import scala.runtime.quoted.Unpickler.Pickled | |||
|
|
|||
| sealed abstract class Expr[T] { | |||
| sealed abstract class Expr[+T] { | |||
There was a problem hiding this comment.
I think it'd make sense to make the subclasses covariant too for consistency.
There was a problem hiding this comment.
Yes, I will add apt them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.